WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#15287 closed defect (bug) (fixed)

Invalid markup in administration pages

Reported by: wahgnube Owned by:
Priority: low Milestone: 3.1
Component: Validation Version: 3.1
Severity: normal Keywords: has-patch commit
Cc:

Description

I have attached a patch which fixes several small validation errors when rendering pages in wp-admin. There are a few more fixes to follow to get all the current core trunk admin pages to render without validation errors.

Attachments (3)

wp-admin-1.patch (2.2 KB) - added by wahgnube 3 years ago.
15287.diff (657 bytes) - added by nacin 3 years ago.
15287.2..patch (5.9 KB) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (14)

wahgnube3 years ago

comment:1 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:2 ryan3 years ago

(In [16817]) Close br. Props wahgnube. see #15287

comment:3 nacin3 years ago

  • Keywords needs-patch added; has-patch removed
  • Priority changed from normal to low

Exisitng patch has issues with each piece. I don't know why some things are changing. We can't pass amp; into wp_redirect. Some appear invalid. Some not.

comment:4 scribu3 years ago

  • Milestone changed from 3.1 to Future Release

No patch, low priority, punting.

comment:5 nacin3 years ago

  • Milestone changed from Future Release to 3.1

Would like new eyes on the wp-admin/includes/template.php change. Are we seeing any issues there with JS or such? Let's fix it if there's an issue.

comment:6 nacin3 years ago

In the case of the wp-admin/edit-comments.php diff, the </div> is for div#wrap and needs to be moved outside of the form, rather than the form moved inside the div.

In the case of the wp-admin/upload.php diff, the </div> should be removed; it is the same issue -- closing div#wrap too early, which is closed later again. If I had to guess, the floating clear is necessary inside the </form>, but the one outside can be removed.

The wp-admin/edit-tags.php diff can be ignored. I can't find $location used for anything beyond redirects, which should not have amp encoding. (As it's a global, some other function might be pulling it in. Leaving it alone.)

In the case of the wp-admin/includes/template.php diff, the ID addmetasub is used only for styling. The addmeta name is, importantly, used in the post handler. This change would break the form. I do not know what this is trying to fix.

nacin3 years ago

comment:7 nacin3 years ago

  • Keywords has-patch added; needs-patch removed

Untested; diff is final for the ticket and just based on studying the code. Need to run validation passes, sanity checks, and confirm that the UI didn't explode.

ocean902 years ago

comment:8 ocean902 years ago

15287.2..patch with some more validation error fixes.

comment:9 nacin2 years ago

Looks fine. Not a fan of the md5, but it works.

comment:10 nacin2 years ago

  • Keywords commit added

comment:11 nacin2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17129]) Validation fixes. props ocean90, fixes #15287.

Note: See TracTickets for help on using tickets.