WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 4 months ago

#15385 new enhancement

Use get_template_part() for post formats in Twenty Ten

Reported by: nacin Owned by:
Priority: normal Milestone: WordPress.org
Component: Bundled Theme Version:
Severity: normal Keywords:
Cc: azizur

Description

Let's encourage some standardization in themes by giving Twenty Ten the following:

get_template_part( 'post-format', 'aside' );
get_template_part( 'post-format', 'gallery' );

We'll leave the default in loop.php, I'm thinking, though we could also use post-format-default.

I'm going to comment on #14746 that I think, if post formats are supported, then 'default' should always be supported and should be enforced as the default, even if nothing is stored yet for that post.

Attachments (1)

15385.diff (21.7 KB) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 markmcwilliams3 years ago

I'd never thought about that, can see logic behind it though! :)

nacin3 years ago

comment:2 nacin3 years ago

Patch attached.

Something doesn't quite feel right. I don't know if it's the arguments in get_template_part(), or the fact that the default styling remains in loop.php, or something.

comment:3 markjaquith3 years ago

  • Milestone changed from 3.1 to Future Release

Punt.

comment:4 azizur3 years ago

  • Cc azizur added

comment:5 SergeyBiryukov6 months ago

  • Component changed from Themes to Bundled Theme

comment:6 SergeyBiryukov4 months ago

  • Milestone changed from Future Release to WordPress.org
Note: See TracTickets for help on using tickets.