Candidates for new template functions based on code in Twenty Ten

[johnbillion]

There are several pieces of code in Twenty Ten which are candidates for abstraction into template functions. I'll make a list shortly and put it up here to get feedback.

[johnbillion]

First up in comments.php we have:

if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) )

This is used twice and would be ideal as a function named comments_paged() instead, giving us:

if ( comments_paged() )

[johnbillion]

In loop.php we have:

if ( $wp_query->max_num_pages > 1 )

It's not nice using the $wp_query object directly so let's put it in a function. posts_paged() would keep it consistent with comments_paged() suggested above.

if ( posts_paged() )

Much nicer.

[nacin]

Been thinking about a replacement for max_mum_pages for a while. Unfortunately, we use 'paged' in the context of page > 2, not total pages > 2. Would be interested to make new functions though.

[johnbillion]

Maybe use the term 'paginated' instead of 'paged' then? Giving us comments_paginated() and posts_paginated(). Might need thinking about.

[johnbillion]

The boat has sailed.

[SergeyBiryukov]

Replying to johnbillion:

First up in comments.php we have:

if ( get_comment_pages_count() > 1 && get_option( 'page_comments' ) )

Related: #17778