Press This is broken

[westi]

• When using Press This, you are unable to add tags to your post.
• Link helper not working

...

[duck_]

15561.js-error.diff fixes an undefined error which blocks AJAX tags from working. Nothing on the link button yet.

[duck_]

15561.001.diff fixes both the tags and the link button. Though some more CSS styles for the link dialog need to be included.

Could press-this.php not make use of admin-header.php to help stop these kind of problems in the future?

[ryan]

(In [16571]) Press This fixes. Props duck_. see #15561

[duck_]

Replying to duck_:

15561.001.diff fixes both the tags and the link button. Though some more CSS styles for the link dialog need to be included.

Okay, one of the missing CSS style sheets for the link dialog is the global style sheet (for example getting rid of the bullets in the search list). But I'll leave that for now, I don't know if this will introduce conflicts with other press-this styles.

Could press-this.php not make use of admin-header.php to help stop these kind of problems in the future?

Answer no. This would include the large admin header, favourite actions, etc. However the current approach for Press This seems a bit annoying for maintenance :(

[scribu]

re maintenance: #14650

[duck_]

Still some styling issues.

[ocean90]

#15758 closed as a dup.

[garyc40]

link dialog style fix

[nacin]

I would rather see these link dialog reset fixes go into wplink.dev.css directly, that way we don't need to maintain two different versions of the link dialog CSS.

[garyc40]

move styles to wplink.css

[nacin]

font-family needs the whole stack. Looks alright otherwise, but I am guessing some of these rules can be merged into the rest of the styles. For example, the toggle-arrow rules can go into toggle-arrow directly.

[garyc40]

use full font stack

[garyc40]

Replying to nacin:

I am guessing some of these rules can be merged into the rest of the styles. For example, the toggle-arrow rules can go into toggle-arrow directly.

Hmm, don't fully understand your suggestion. I'm guessing you mean using rules that are defined elsewhere instead of porting those rules from other stylesheets to wplink.css?

The problem with press this is that it has its own stylesheet (press-this.css) and doesn't inherit from base css files (such as global.css or wp-admin.css). As a result, lots of code duplication there. But since including these global and wp-admin stylesheets would be costly in terms of overhead, I don't see any other solution than copypasta. Splitting up wp-admin.css into smaller components that press-this can inherit might work, although that would be a bit unwieldy.

[nacin]

Sorry, I figured that some of those selectors you added to the top of the file were repeated later in the file, and that some of those properties could be moved and thus declaration blocks combined.

I now see that's not necessarily the case.

Posting a patch that shifts things around into a slightly more logical order (doesn't change any CSS), and asking koopersmith to review it. Thanks for the patch.

[nacin]

Still having issues with long titles.

[dd32]

Closed #15886 as a dup of this:

Press This's Category metabox's tabs have a White background on the <a>.

This background is coming from `body.press-this .tabs a, body.press-this
.tabs a:hover `. The .tabs class is not used elsewhere and appears to be a
left over fragment from something else.

Attached patch removes the stylings for the .tab class, and brings the
styling inline with the standard editor by applying a #333 link colour
whilst the tab is selected.

[duck_]

Replying to dd32:

Closed #15886 as a dup of this:

Press This's Category metabox's tabs have a White background on the <a>.

This background is coming from `body.press-this .tabs a, body.press-this
.tabs a:hover `. The .tabs class is not used elsewhere and appears to be a
left over fragment from something else.

Attached patch removes the stylings for the .tab class, and brings the
styling inline with the standard editor by applying a #333 link colour
whilst the tab is selected.

I actually remember doing this ages ago. See #12809, [14149] and [14150] (last one fix for colors-classic too). Looks like it might have been accidentally reverted in the next commit against colors-fresh.dev.css for nav menus.

[dd32]

I actually remember doing this ages ago.

Me too, I had however, thought it was the normal admin category metabox :)

[ryan]

Per IRC discussion, all patches are good for commit. This ticket will be left open for further tweaks.

[ryan]

wplink patches need refresh.

[garyc40]

wplink patch refreshed

[nacin]

Latest wplink patch needs refresh again.

[garyc40]

my bad, refreshed again

[garyc40]

reverted change in wp-admin.css

[ocean90]

Set font-size: 12px.

[nacin]

(In [17131]) Fix some tab CSS in Press This. props dd32. Also adjust menu bits to default to gray, and then add rules to blue. see #15561.

[dremeda]

Seems good now Nacin.

[ocean90]

[17133]

[nacin]

Great. All patches here are committed.

Press This needs final RTL and IE6 checks. Internal linking in both Press This and post-new should be checked for long titles as well (including in IE6, RTL, and both IE6 and RTL).

Please check off what you've tested.

[dremeda]

I've checked latest Mac browsers (FF/Chrome/Safari/Opera).

[nacin]

Final checks for internal linking (IE6, RTL, long titles) need to be reported to #15739.

[nacin]

(In [17135]) More CSS reset for wplink. Give the dialog title a specific line height. see #15561.

[nacin]

[17135] is designed to fix ​http://cl.ly/3a1k2y1I0a3I263j2a08.

[ocean90]

Long titles and the internal linking box are fine in IE6/7 and Opera.

IE6-8 problem: In Press This the internal linking box is empty: ​http://grab.by/842L

[nacin]

Any inkling as to why? I'll try to fire IE8 up on a machine.

[ocean90]

It's a no-go, that we add the HTML code for the dialog (wp_link_dialog()) in the <head> tag. This could be the problem in IE, but I can't test more yet.

[ocean90]

15561.quickdirty.patch will fix the bug. Now it works in IE6,7 and 8 too. Related changeset r16571. Patch is quick&dirty, don't have the time. Merry christmas. :-)

[nacin]

(In [17140]) Delay wp_tiny_mce_preload_dialogs to the footer, as occurs in admin-header. props ocean90, fixes #15561.