WP_Users_List_Table queries post counts in network admin

[westi]

When this table is displayed in the network admin for sites-users.php it calls count_many_users_posts in display_rows even when we are not going to display this info.

[westi]

Also is there a reason why the class attribute $site_id isn't called $blog_id because sites are different (One MS install can have many sites each with many blogs) so this is a confusing var name.

[scribu]

Avoind redundant call to count_many_users_posts()

[scribu]

Replying to westi:

Also is there a reason why the class attribute $site_id isn't called $blog_id because sites are different (One MS install can have many sites each with many blogs) so this is a confusing var name.

The network admin already broke the site/blog convention: /network/site-*.php

So, don't know which would be less confusing.

[nacin]

Files are fine. Code should be 'blog', never 'site'.

Actually, that means we should probably have WP_Blogs_List_Table, rather than WP_MS_Sites_List_Table. Surprised I didn't notice that before.

[nacin]

(In [16775]) Don't check post counts in the network admin. props scribu, fixes #15699.

[nacin]

(In [16794]) Fix logic inversion. see #15699.