Opened 2 years ago

Last modified 2 weeks ago

#15765 new defect (bug)

wp-admin/ms-sites.php doesn't indicate required fields

Reported by: novasource Owned by:
Priority: normal Milestone: 3.6
Component: Network Admin Version: 3.0.2
Severity: minor Keywords: ui-feedback has-patch commit
Cc: aren@…, info@…

Description

In wp-admin/ms-sites.php, apparently all fields under Add Site are required, but there is no visual indication.

Attachments (3)

required-fields.diff​ (1.6 KB) - added by wonderboymusic 7 months ago.
15765.patch​ (7.0 KB) - added by toscho 5 months ago.
Add 'required' attribute to prevent accidental submissions. Fix code style violations en passant.
15765.2.patch​ (2.7 KB) - added by DrewAPicture 2 weeks ago.

Download all attachments as: .zip

Change History (10)

comment:1   ocean90 — 2 years ago

With 3.1 it's wp-admin/network/site-new.php.

comment:2   nacin — 2 years ago

  • Component changed from UI to Network Admin
  • Keywords ui-feedback added
  • Milestone changed from Awaiting Review to Future Release

wonderboymusic — 7 months ago

comment:3   wonderboymusic — 7 months ago

  • Keywords has-patch added

Added required using same HTML as the edit-user.php form, including label with the for attribute. Patched.

comment:4   nacin — 5 months ago

  • Milestone changed from Future Release to 3.6

toscho — 5 months ago

Add 'required' attribute to prevent accidental submissions. Fix code style violations en passant.

comment:5   toscho — 5 months ago

  • Cc info@… added

To prevent useless submissions I have added the required attribute. Browsers supporting this will show a warning message, and they will prevent a form submission.

DrewAPicture — 2 weeks ago

comment:6   DrewAPicture — 2 weeks ago

15765.2.patch​ combines required-fields.diff with just adding the required attributes to the three inputs.

comment:7   DrewAPicture — 2 weeks ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.