Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#15885 closed defect (bug) (fixed)

on edit comments screen "comments filter" does not work

Reported by: greuben Owned by:
Priority: normal Milestone: 3.1
Component: Comments Version: 3.1
Severity: blocker Keywords: has-patch dev-reviewed
Cc:

Description

On edit comments screen select "pings" from the comment filter and click filter, it says no items even if I have pingbacks and trackbacks

Attaching a patch which fixes it.

Attachments (1)

15885.diff​ (840 bytes) - added by greuben 2 years ago.

Download all attachments as: .zip

Change History (8)

greuben — 2 years ago

comment:1   greuben — 2 years ago

  • Component changed from General to Comments
  • Severity changed from normal to blocker

I think its a blocker.

comment:2   nacin — 2 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:3   dd32 — 2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17052]) Fix Pings/Trackback comment table filter. Props greuben. Fixes #15885

comment:4   dd32 — 2 years ago

(In [17053]) Revert debug cruft from r17052. See #15885

comment:5   greuben — 2 years ago

hmm....that debug cruft isn't in my patch? how did it enter?

comment:6   nacin — 2 years ago

dd32 had code in his testbed from testing probably #15676.

Patch looked good, I was looking it over and nodded to Dion.

comment:7   westi — 2 years ago

  • Keywords dev-reviewed added

Change looks good here too.

Note: See TracTickets for help on using tickets.