Opened 2 years ago

Closed 2 years ago

#15940 closed defect (bug) (fixed)

Plugin deletion error

Reported by: phill_brown Owned by:
Priority: normal Milestone: 3.1
Component: Plugins Version: 3.1
Severity: normal Keywords: has-patch commit
Cc:

Description (last modified by scribu)

I'm getting this error after deleting plugins:

Could not fully remove the plugin(s) Array.

An extra, 'checked', input field is added the form on the confirmation page. The bug stems from line 237 in /wp-admin/plugins.php, where plugin file data is added to the $plugins array.

In 3.0 a temporary variable was used which was then changed in r15491. Switching back to using a separate variable appears to fix the problem?

Attachments (1)

plugins.patch​ (829 bytes) - added by phill_brown 2 years ago.

Download all attachments as: .zip

Change History (6)

comment:1   nacin — 2 years ago

  • Milestone changed from Awaiting Review to 3.1

phill_brown — 2 years ago

comment:2   scribu — 2 years ago

  • Description modified (diff)
  • Keywords has-patch added

comment:3   dd32 — 2 years ago

Patch looks good to me

comment:4   scribu — 2 years ago

  • Keywords commit added

I guess I did that thinking that $plugins['folder'] would be used later on. Looks good to me too.

comment:5   nacin — 2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17106]) Use a separate variable to fix plugin deletion. props phill_brown, fixes #15940.

Note: See TracTickets for help on using tickets.