WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#16119 closed defect (bug) (fixed)

Incorrect variable assignment in wp-admin/network/themes.php

Reported by: westi Owned by: westi
Priority: highest omg bbq Milestone: 3.1
Component: Network Admin Version: 3.1
Severity: normal Keywords: has-patch commit
Cc:

Description 

$_GET['disabled'] = absint( $_GET['deleted'] );
echo '<div id="message" class="updated"><p>' . sprintf( _n( 'Theme deleted.', '%s themes deleted.', $_GET['deleted'] ), number_format_i18n( $_GET['deleted'] ) ) . '</p></div>';

Should be:

$_GET['deleted'] = absint( $_GET['deleted'] );
echo '<div id="message" class="updated"><p>' . sprintf( _n( 'Theme deleted.', '%s themes deleted.', $_GET['deleted'] ), number_format_i18n( $_GET['deleted'] ) ) . '</p></div>';

Attachments (1)

16119.diff​ (1000 bytes) - added by westi 2 years ago.
Patch

Download all attachments as: .zip

Change History (5)

westi — 2 years ago

Patch

comment:1 nacin — 2 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.1
  • Priority changed from normal to highest omg bbq

Checking other spots too.

comment:2 nacin — 2 years ago

site-themes.php looks good. The deleted branch is only here and it's the only spot incorrect. This was mine I think, via [17130].

comment:3 westi — 2 years ago

(In [17230]) Ensure that we apply the absolute integer casting result to the variable we are going to use. See #16119

comment:4 westi — 2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I've looked through other absint calls like this and they all look ok.

Marking as Fixed

Note: See TracTickets for help on using tickets.