WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#16224 closed defect (bug) (fixed)

format-standard class unnecessary for pages

Reported by: iandstewart's profile iandstewart Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

If post formats are meant only for posts it seems unnecessary to include format-standard in the post classes for pages.

Attachments (2)

post-format-classes.diff​ (515 bytes) - added by iandstewart 13 years ago.
post-format-classes-2.diff​ (758 bytes) - added by iandstewart 13 years ago.

Download all attachments as: .zip

Change History (6)

@iandstewart
13 years ago

#1 follow-up: @nacin
13 years ago

  • Milestone changed from Awaiting Review to 3.1

We should probably instead use if ( post_type_supports( $post->post_type, 'post-formats' ) ).

#2 in reply to: ↑ 1 @westi
13 years ago

Replying to nacin:

We should probably instead use if ( post_type_supports( $post->post_type, 'post-formats' ) ).

Agreed

@iandstewart
13 years ago

#3 @iandstewart
13 years ago

Updated patch to exclude any post type that doesn't use post formats.

#4 @nacin
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17292]) Only add the post format post classes when the post type supports post formats. posts posts posts posts. props iandstewart, fixes #16224.

Note: See TracTickets for help on using tickets.