Menu items get deleted with the user who created them

[nacin]

Say a user edits a nav menu or two, adding some menu items. Then, said user gets deleted. Rut roh:

SELECT ID FROM $wpdb->posts WHERE post_author = %d

The menu items were tied to them, therefore they are deleted.

We need to ensure that wp_delete_user() doesn't touch nav menu items.

This has repercussions for any post type that doesn't care about authors. Tempted to actually check, post_type_supports(), which is typically reserved for UI-level actions. Otherwise, post_author always gets stored, and that seems to be just a bit of a problem. (It could be argued this is a UI-level check, in terms of confirming things to delete.)

Unsure how this didn't come up previously. Reported by flashingcursor over Twitter.

[nacin]

To be honest, it says 'posts and links'. We do fire an action there that custom post types could use.

Tempted to hard restrict it to posts, pages, and attachments.

Moving to 3.1. This one seems bad.

[nacin]

Restrict to posts, pages, attachments.

[nacin]

In patch 1, I forgot revision. You get the idea.

Second patch leverages post_type_supports.

[nacin]

Option 3 is to avoid deleting nav menu items only, and leave CPT handling to a filter, with the default of delete. (Default of not delete would be option 1.)

[nacin]

Patch might overlap with #16359.

Note, probably goes without saying, but none of these were actually tested. We need a plan of action on which to choose, more importantly.

[westi]

This is not a regression in 3.1 so can wait till 3.2 to be fixed.

[nacin]

Would not mind a `AND post_type <> 'nav_menu_item' in 3.1. This is a nasty dumb bug.

[filosofo]

I like the idea of doing this based on whether the post type supports authors, as that generalizes well.

Is there any reason the core post type definitions don't declare author support for revisions and attachments?

[WraithKenny]

I also like your second patch (post type supports authors)

[jane]

Bummed this keeps getting punted. I think it definitely falls into 'making your site look the way you want it to look' plan, for 3.4, so let's see if someone can work on this for 3.4 early.

[ryan]

delete_with_user flag. Props nacin

[ryan]

That patch also changes to a force delete instead of putting posts in trash.

[ryan]

Use trash instead of force delete. Add phpdoc.

[nacin]

Looks good.

[ryan]

In [20739]:

Don't delete nav menu items when the user that owns them is deleted.

• Introduce delete_with_user flag to register_post_type
• Set delete_with_user to false for the nav_menu_item post type
• Set it to true for all other core post types
• If delete_with_user is not set, fallback to post_type_supports('author')

Props nacin
Fixes #16358

[ryan]

​http://unit-tests.trac.wordpress.org/changeset/712