Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#16531 closed defect (bug) (fixed)

Context is missing from some "Name" strings

Reported by: valentinas Owned by: azaozz
Priority: normal Milestone: 3.2
Component: I18N Version: 3.1
Severity: normal Keywords: has-patch 3.2-early commit
Cc: pavelevap@…, valentinas, nacin

Description

Name of a person and name of a link, plugin, meta, etc are translated differently, therefore they need context.

Attachments (1)

add_context_name.patch (5.1 KB) - added by valentinas 2 years ago.
Patch to add context to "Name" where refers to something else than person.

Download all attachments as: .zip

Change History (13)

Patch to add context to "Name" where refers to something else than person.

  • Keywords has-patch added
  • Cc pavelevap@… added

Great, I made the same ticket some months ago, but without patch...

http://core.trac.wordpress.org/ticket/14237

Would be nice to have this committed to 3.1 if thats possible. This issue prevents WP for being fully localized. You will either have wrong meaning or will need to hack the core.

  • Keywords 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

It' too late for 3.1, because we are already in RC4 and in string freeze.

Last edited 2 years ago by ocean90 (previous) (diff)
  • Cc valentinas added

Bump, any chance to commit this patch for 3.2?

  • Cc nacin added
  • Keywords commit added
  • Milestone changed from Future Release to 3.2

Fine. Does it need further refresh?

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18247]:

Add context to _e('Name'), props valentinas, fixes #16531

Great, works well. Name without context is now used only for several strings which are related to Users.

Only one note: It is needed to have one string "Name" and other string "Name:" (with colon) for only one context "html attribute"?

Name without context is now used only for several strings which are related to Users.

Submit a patch and we can add context to those too.

It is needed to have one string "Name" and other string "Name:" (with colon) for only one context "html attribute"?

Could you elaborate or try again? All names were given context, including Name:. There probably isn't another Name:, but regardless, this one has nice context now.

OK, I will try to add patch, but it is not important because all of these remaining strings are related to users (living things) and there is only one context (user) for them.

Yes, it is not problem, context is fine. My English is poor, so I did not explain it well. I only noted that there are 2 strings "Name" and "Name:" with the same context "html attribute" which differ by colon. Removing colon from translation (and adding it directly to script) we would need only one string to translate and not two with the same meaning...

Note: See TracTickets for help on using tickets.