Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#16704 closed defect (bug) (fixed)

Do not do canonical redirects for unregistered feeds

Reported by: ryan Owned by:
Priority: normal Milestone: 3.1.1
Component: Canonical Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Description

Canonical redirects will break unregistered feeds since they are not includes in the rewrite rules. Several plugins go underneath instead of using add_feed().

Discovered here:

​http://wordpress.org/support/topic/31-rewrites?replies=6

Attachments (1)

16704.diff​ (497 bytes) - added by ryan 2 years ago.

Download all attachments as: .zip

Change History (6)

comment:1   ryan — 2 years ago

  • Component changed from General to Canonical
  • Milestone changed from Awaiting Review to 3.1.1
  • Version set to 3.1

ryan — 2 years ago

comment:2   ryan — 2 years ago

  • Keywords has-patch added

comment:3   ryan — 2 years ago

Looking good so far with this test plan:

  • Visit /feed/ and /category/uncategorized/feed/, verify no redirect
  • Visit ?feed=rss2 and /category/uncategorized/?feed=rss2, verify canonical redirect to /feed/...
  • Do 1 and 2 above with a non-default core feed like atom.
  • Register a feed and do 1 and 2 above.
  • Visit an unregistered feed and verify that there is no canonical redirect and that the "not a valid feed template" message is displayed.

comment:4   ryan — 2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17498]) Do not do canonical redirects for unregistered feeds. fixes #16704 for trunk

comment:5   ryan — 2 years ago

(In [17499]) Do not do canonical redirects for unregistered feeds. fixes #16704 for 3.1

Note: See TracTickets for help on using tickets.