Automatically set 'compare' => 'IN', when meta value is an array

[scribu]

This should just work:

get_posts( array(
  'meta_key' => 'foo',
  'meta_value' => array( 'bar', baz' )
) );

Currently, you have to remember to set meta compare:

get_posts( array(
  'meta_key' => 'foo',
  'meta_value' => array( 'bar', baz' ),
  'meta_compare' => 'IN'
) );

Obviously, it should be the same when using 'meta_query'.

[ldebrouwer]

Patch that defaults $meta_compare to 'IN' if $qcompare? is not set and $qvalue? is an array.

[ldebrouwer]

Added the patch, sorry for the crappy description of it. It defaults $meta_compare to 'IN' if $meta_compare is not set and $meta_value is an array.

[ldebrouwer]

Needs testing of course..

[scribu]

Please make your patches relative to the wp root dir, not to wp-includes.

[ldebrouwer]

Sorry about that!

[ldebrouwer]

Same patch, just relative to the WP root dir unlike the previous one.

[scribu]

Marked #18401 as dup.

[scribu]

Note that if you're trying to match against an actual array as a value, you will have to manually apply maybe_serialize() on it. Also, you can still explicitly set the 'compare' parameter to '='.

[Doggie52]

Replying to scribu:

Note that if you're trying to match against an actual array as a value, you will have to manually apply maybe_serialize() on it. Also, you can still explicitly set the 'compare' parameter to '='.

What do you mean? If what you're matching against (i.e. the DB entry) is serialized? If you know that data is serialized then you'll of course serialize your value - am I wrong? Why point such a thing out?

[scribu]

Because some people might expect that when using meta_query, the value will automatically be serialized for them, like it is when using update_post_meta(), for instance.

[ldebrouwer]

Maybe that's something for the codex page on get_posts().

[scribu]

No, I don't think we should mention in on the Codex, since storing arrays in custom fields and then trying to match against them is a bad idea anyway.

[duck_]

Looks good, but needs a refresh. Would need to move the code defining and validating $meta_compare to below $meta_value = $q['value']; (line 740).

Also, does anybody else think it would be a bit more readable if is_array( $meta_value ) sets the default which gets overridden if isset( $q['compare'] )? For example:

$meta_compare = is_array( $meta_value ) ? 'IN' : '=';
if ( isset( $q['compare'] ) )
    $meta_compare = strtoupper( $q['compare'] )

[scribu]

Yes, that would be more readable.

[duck_]

In [18825]:

Automatically set 'compare' => 'IN' in WP_Meta_Query::get_sql() when the meta value is an array. Props ldebrouwer, SergeyBiryukov. Fixes #16829.