Add JS detection to wp_iframe output

[jacobwg]

Currently any page in the admin area includes the necessary script to add the js and no-js classes to the body (from admin-header.php), but this code is missing from the output of the wp_iframe function.

In particular, the upload media popup (/wp-admin/media-upload.php) makes use of hide-if-no-js classes, and without the detection script in place in wp_iframe, those classes will not take effect.

[jacobwg]

Adds body class and JS code necessary for the hide-if-js and hide-if-no-js classes to function

[greuben]

In particular, the upload media popup

These popups only work if js is enabled. So adding them makes no sense

[jacobwg]

The classes exist and should function - in particular the hide-if-js class should function as JS is enabled.

Yes, the popups only work if js is enabled, but the wp_iframe function is not JS specific.

[scribu]

The classes exist and should function - in particular the hide-if-js class should function as JS is enabled.

Yes, but your patch doesn't address that, or rather it could do it more directly, by just adding the 'js' class, if that's what's needed.

[jacobwg]

Should I just add the js class, then, or is there ever a case where we'll use an iframe for something that might work without JS enabled?

[jacobwg]

Adds only the 'js' class - no JS detection

[Dd32]

The first patch looks like the way to go, allows the maximum compatibility and reuse of code between iframes and the normal admin pages

[azaozz]

Was thinking to add the second patch for the reason @greuben points out, but @Dd32 makes a good point too. Currently we don't use this iframe outside the JS dialog but we may use it in the future.

[dd32]

I was mainly thinking of plugins injecting HTML into the iframes, I'd expect plugins to re-use html between iframe and non-iframe pages.. having the js css classes avilable would be of great benefit for non-js support in those cases.

[azaozz]

In [17971]:

Add JS detection to wp_iframe output, remove "display:none" from the Flash uploader button, props jacobwg, fixes #17473