Opened 2 years ago

Closed 20 months ago

#17697 closed defect (bug) (fixed)

Notice: Undefined index: subdomain_install in wp-admin/network.php on line 526

Reported by: cyberhobo Owned by: duck_
Priority: normal Milestone: 3.3
Component: Warnings/Notices Version: 3.2
Severity: normal Keywords: has-patch dev-feedback
Cc: cyberhobo@…

Description

I get this notice in Tools -> Network Setup after clicking Install on an existing single site install with a post more than one month old.

There's a more notice-resistant version of the same check earlier in the code - I'll try that and submit a patch shortly.

Attachments (2)

17697.diff​ (708 bytes) - added by cyberhobo 2 years ago.
Patch
17697.patch​ (713 bytes) - added by SergeyBiryukov 21 months ago.
Switched the condition, as per coding standards

Download all attachments as: .zip

Change History (7)

cyberhobo — 2 years ago

Patch

comment:1   cyberhobo — 2 years ago

  • Keywords has-patch added; needs-patch dev-feedback removed

comment:2   cyberhobo — 2 years ago

  • Component changed from General to Upgrade/Install

Yep - easy fix appears to work fine.

comment:3   cyberhobo — 2 years ago

  • Component changed from Upgrade/Install to Warnings/Notices
  • Keywords dev-feedback added

Maybe I should have left dev-feedback on this? Nacin suggested the patch at WordCamp Reno, seems like a slam-dunk fix to get into 3.2.

SergeyBiryukov — 21 months ago

Switched the condition, as per coding standards

comment:4   SergeyBiryukov — 21 months ago

  • Milestone changed from Awaiting Review to 3.3

comment:5   duck_ — 20 months ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [18692]:

Fix undefined index "subdomain_install" in wp-admin/network.php. Props cyberhobo, SergeyBiryukov. Fixes #17697.

Note: See TracTickets for help on using tickets.