wp-activate.php fails to load properly

[frumph]

wp-activate.php calls get_header(); it comes from the theme, if the theme has functions called from the functions.php it fatal errors out. So noone can activate their registered accounts.

wp-activate.php needs to load up the themes functions.php before calling the get_header(); get_footer();

[nacin]

Oooh, I had said this wasn't a regression over Twitter, but it is. Broken in [17727].

[nacin]

WP_INSTALLING is defined in five situations:

1. wp-activate.php, unsure original reason, but it prevents non-network plugins (plugins on the main site) from loading
2. wp-admin/install.php - initial installation
3. wp-admin/setup-config.php - config file creation
4. wp-admin/upgrade.php - DB upgrades
5. wp-includes/ms-functions.php - wpmu_create_blog()

This is a bit of hack, but we could introduce a new WP_ACTIVATING constant that is checked against:

if ( ! defined( 'WP_INSTALLING' ) || defined( 'WP_ACTIVATING' ) ) {

Since WP_INSTALLING is normally not going to be defined, this doesn't add any more overhead to typical pages, only on installing pages, which are already heavy. But it'll prevent an issue on activation.

[nacin]

I realized $pagenow will tell us the PHP_SELF in this case. Second patch does that.

If we want to make this more flexible, we can do a WP_LOAD_THEM_ANYWAY constant. I'm thinking $pagenow is fine.

[ryan]

In [18263]:

Load the theme's functions.php for wp-activate.php. Props nacin, frumph. fixes #17761