Opened 23 months ago

Closed 23 months ago

#17942 closed defect (bug) (fixed)

DFW in multisite needs to check media_buttons

Reported by: nacin Owned by: azaozz
Priority: high Milestone: 3.2
Component: General Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

Originally reported here: ​http://wordpress.org/support/topic/unable-to-upload-media-in-fullscreen-mode?replies=9.

Attachments (2)

17942.diff​ (618 bytes) - added by nacin 23 months ago.
17942-2.patch​ (1.5 KB) - added by azaozz 23 months ago.

Download all attachments as: .zip

Change History (9)

nacin — 23 months ago

comment:1   nacin — 23 months ago

  • Keywords has-patch added

comment:2 follow-up: ↓ 3   nacin — 23 months ago

Alternative would be to trigger #add_media, which seems to allow some things, but I don't really know what.

comment:3 in reply to: ↑ 2   vebailovity — 23 months ago

Replying to nacin:

Alternative would be to trigger #add_media, which seems to allow some things, but I don't really know what.

Maybe something along these lines in onclick handler:

(jQuery('#add_image').length ? jQuery('#add_image').click() : jQuery('#add_media').click());return false;

azaozz — 23 months ago

comment:4   azaozz — 23 months ago

Alternatively we can make the Insert Media button in DFW open the Add Media popup on ms if the Add Image button is disabled (the default), as suggested by @nacin.

Last edited 23 months ago by azaozz (previous) (diff)

comment:5   nacin — 23 months ago

  • Keywords commit added

+1 on 17942-2.patch.

comment:6   ryan — 23 months ago

Another +1 on 17942-2.patch

comment:7   azaozz — 23 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18380]:

DFW: check if the Add Image button is enabled in ms mode before using it, props nacin, fixes #17942

Note: See TracTickets for help on using tickets.