Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#17997 closed enhancement (invalid)

Code cleanup, minor code enhancements to "misc.php"

Reported by: Latz Owned by:
Priority: normal Milestone:
Component: General Version:
Severity: minor Keywords: has-patch
Cc:

Description

I've added an amount of spaces to the code to make it WP coding standard compliant, changed " to ' where appropriate and added ";" at single line <?php ... ?> structures.

Attachments (1)

misc.diff (18.4 KB) - added by Latz 23 months ago.

Download all attachments as: .zip

Change History (5)

Latz23 months ago

Please take a look at http://wpdevel.wordpress.com/2011/03/23/code-refactoring/

Also I don't think we are using spaces between square brackets.

In your post to wp-hackers you stated:

I was changing spacing for a function anyway because it was horrible to read and to understand

This is a good reason to refactor a particular piece of code. Refactoring the whole file, however, is not necessary. It should be avoided for the reasons pointed out in the WP Devel link above.

Which function were you originally refactoring to improve the readability of? IMO you should resubmit a patch with just the refactoring you originally intended.

  • Resolution set to invalid
  • Status changed from new to closed
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.