WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 20 months ago

#18001 closed defect (bug) (wontfix)

tiny_mce_preload_dialogs hook just disappeared

Reported by: dvankooten Owned by: azaozz
Priority: normal Milestone:
Component: Editor Version: 3.2
Severity: normal Keywords: 2nd-opinion dev-feedback
Cc:

Description

Apparently, wp_tiny_mce_preload_dialogs() got removed and has changed into wp_preload_dialogs(). The tiny_mce_preload_dialogs hook just disappeared with this, breaking a lot of plugins.

wp-admin/includes/post.php differences (3.1.4 > 3.2)

Change History (6)

comment:1 kawauso2 years ago

Looks like it was removed in [17785], part of Distraction Free Writing.

https://core.trac.wordpress.org/changeset/17785/trunk/wp-admin/includes/post.php

See also: #17136

Last edited 2 years ago by kawauso (previous) (diff)

comment:2 nacin2 years ago

  • Milestone changed from Awaiting Review to 3.2.1

comment:3 nacin2 years ago

  • Owner set to azaozz
  • Status changed from new to reviewing

comment:4 azaozz2 years ago

This was an internal hook for the wp-links dialog and was replaced by two new hooks when DFW was implemented. At the time no plugin was using it, so didn't see the need to keep it.

There are some planned enhancements to the_editor() and wp_tiny_mce() for 3.3 that will change how plugins use both editors anyways. Also the new hooks, before_wp_tiny_mce and after_wp_tiny_mce will stay for sure :)

comment:5 azaozz2 years ago

  • Component changed from TinyMCE to Editor
  • Milestone 3.2.1 deleted
  • Resolution set to wontfix
  • Status changed from reviewing to closed

Closing as wontfix, if there are still plugins that try to use the old hook, it would be best to update them. An update for them would probably be needed for 3.3 in any case.

comment:6 downloadbook20 months ago

Nothing.

Last edited 20 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.