Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#18071 closed defect (bug) (fixed)

Twenty Eleven: TEMPLATEPATH to get_template_directory()

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Some setups (including WP.com) may filter get_template_directory(). We should use this instead of TEMPLATEPATH directly in Twenty Eleven.

Twenty Ten did this too.

Attachments (2)

18071.diff (827 bytes) - added by solarissmoke 14 years ago.
18071.2.diff (1.5 KB) - added by solarissmoke 14 years ago.
Change both Twenty Ten and Twenty Eleven

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
14 years ago

  • Keywords needs-patch added

@solarissmoke
14 years ago

#2 follow-up: @solarissmoke
14 years ago

  • Keywords has-patch added; needs-patch removed

Can we change Twenty Ten also?

#3 in reply to: ↑ 2 @SergeyBiryukov
14 years ago

  • Milestone changed from Awaiting Review to 3.3

Replying to solarissmoke:

Can we change Twenty Ten also?

I guess so, as it's still a bundled theme.

@solarissmoke
14 years ago

Change both Twenty Ten and Twenty Eleven

#4 follow-up: @solarissmoke
14 years ago

  • Keywords close added

Looking a bit closer, TEMPLATEPATH itself is defined using get_template_directory(), so doing it again in the theme seems redundant?

#5 in reply to: ↑ 4 @aaroncampbell
14 years ago

Replying to solarissmoke:

Looking a bit closer, TEMPLATEPATH itself is defined using get_template_directory(), so doing it again in the theme seems redundant?

Someone could filter based on some condition, so they could filter DIFFERENTLY in different places.

See #18298

#6 @SergeyBiryukov
14 years ago

  • Keywords close removed

#7 @nacin
14 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19058]:

Use get_template_directory() instead of TEMPLATEPATH in Twentys Ten and Eleven. props solarisssmoke, fixes #18071.

Note: See TracTickets for help on using tickets.