Opened 22 months ago

Closed 22 months ago

#18291 closed defect (bug) (fixed)

Incorrect grammar in user notification email

Reported by: johnbillion Owned by: ryan
Priority: normal Milestone: 3.3
Component: Multisite Version: 3.2.1
Severity: normal Keywords: has-patch
Cc:

Description

When a new user is added to a site as an editor, the activation email says "You've been invited to join {site} at {url} as a editor." which is grammatically incorrect.

Not sure of the best way to fix this. A phonetic helper would be overkill, especially when it comes to i18n. Maybe we need to introduce labels for user roles (similar to labels for CPTs and taxos), or just change the wording of the email.

PS thought this had been addressed before but a Trac search brought up nothing.

Attachments (1)

18291.patch​ (1.3 KB) - added by SergeyBiryukov 22 months ago.

Download all attachments as: .zip

Change History (4)

comment:1   nacin — 22 months ago

The string is terrible, but "with the role of $%s" should be fine. At least it'll be grammatically correct.

SergeyBiryukov — 22 months ago

comment:2   SergeyBiryukov — 22 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

comment:3   ryan — 22 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18487]:

Grammar fix. Props SergeyBiryukov, johnbillion. fixes #18291

Note: See TracTickets for help on using tickets.