Incorrect WP_Error in image_resize

[mzaweb]

image_resize in wp-includes/media.php (line 417)

$dims = image_resize_dimensions($orig_w, $orig_h, $max_w, $max_h, $crop);
if ( !$dims )
    return new WP_Error( 'error_getting_dimensions', __('Could not calculate resized image dimensions') );

But image_resize_dimensions return false if the new dimensions are bigger or equal the old ones, assuming that you won't want to resize the image.

// if the resulting image would be the same size or larger we don't want to resize it
if ( $new_w >= $orig_w && $new_h >= $orig_h )
    return false;

If this is the intended functionality, it shouldn't throw a WP_Error. I think the check for if we want to resize or not should be done in image_resize instead.

[mzaweb]

moved the validation to image_resize

[SergeyBiryukov]

Version field indicates the earliest version the bug has been found in, let's keep it at 3.2.1.

[prockrammer]

This defect exists on 3.3.1 too. Please add the patch

[helenyhou]

SergeyBiryukov:

Version field indicates the earliest version the bug has been found in, let's keep it at 3.2.1.

[vhauri]

+1

[misterbisson]

Good patch @mzaweb . I'd love to see this in core.

[markoheijnen]

The error is intended. You want to resize an image and if that doesn't happend you want an error.
Returning $file implies that the file did got resized.

[markoheijnen]

I'm closing this ticket since my opinion isn't changed on this. Also moving the check from image_resize_dimensions() would allow upscaling when it is used in plugins. Upscale support is fine but it should be consistent.

Also the patch isn't valid anymore since image_resize is deprecated and has been rewritten to use WP_Image_Editor