C-style hexadecimal is incorrectly "fixed" to change the 'x' into a mathematical '×'

[harrym]

Pretty much what the title says. I'm running trunk. "0x07" gets converted to "0×07".

I've attached a patch which fixes this issue by not performing the conversion if the first number starts with a zero -- this is not perfect, and I might have a go at something better when it's not 0030, if you guys decide this should be changed.

My $0.02 - since it's a bit odd to multiply zero by something, I don't think that very many people will expect/want this conversion to happen -- and the lack of conversion is unlikely to confuse those that do.

On the other hand, this conversion is confusing for any blog post using this hex notation, and does make those posts actually wrong.

[nacin]

At a glance, patch looks great! We'll want unit tests for this.

[kurtpayne]

Allowing for decimals, commas, negative signs

[kurtpayne]

Unit test wptexturize('AxB') for comma, decimal, and hex numbers

[harrym]

Now that this has tests, could it be included in 3.7?

[helen]

Too late for 3.7. Maybe 3.8 - patch needs a refresh to account for new develop repo and probably @ticket annotation for the tests.

[miqrogroove]

In miqro-19308.patch:

• Unit tests from kurtpayne.
• A new regexp that uses conditions instead of alternation.
• It looks for a word break, a single digit, and then tests if that digit is zero.
• This prevents the engine from testing multiple alternates after every word break.
• Decimals and commas are allowed after the first digit.
• Hyphen (negative) also allowed as the first char after the x.

[miqrogroove]

Allow a hyphen in preg_match as well.

[wonderboymusic]

In 28719:

In wptexturize(), don't convert C-style hexadecimals to mathematical ×.

Adds unit tests.

Props harrym, kurtpayne, miqrogroove.
Fixes #19308.