Ticket #19364 (closed enhancement: fixed)

Opened 3 months ago

Last modified 4 weeks ago

Mark http://wordpress.org URL for translation

Reported by: zeo Owned by: nacin
Priority: normal Milestone: 3.4
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc:

Description

  • Remove the trailing slash to match the same string in wp-includes/admin-bar.php#L96
  • Remove unnecessary <span class="hide">...</span>
  • Minor cleanup

Feel free to tweak the original patch

Attachments

19364.diff Download (1.4 KB) - added by zeo 3 months ago.

Change History

zeo — 3 months ago

comment:1 follow-up: ↓ 2   nacin — 3 months ago

  • Type changed from defect (bug) to enhancement

Seems fine. Do we translate " http://wordpress.org/" anywhere else yet?

comment:2 in reply to: ↑ 1   Zeo — 3 months ago

Replying to nacin:

Do we translate " http://wordpress.org/" anywhere else yet?

None in core and MS POT. That's why I remove the trailing slash in the patch.

But " http://wordpress.org/" is currently used in http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyten/footer.php#L33 and http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyeleven/footer.php#L27

Not sure whether we should stick with or without /

comment:3   nacin — 3 months ago

I just opened #19427 to handle " http://wordpress.org/" being translated properly.

We can run with this for 3.4.

comment:4   nacin — 4 weeks ago

  • Owner set to nacin
  • Status changed from new to accepted
  • Milestone changed from Awaiting Review to 3.4

comment:5   nacin — 4 weeks ago

  • Status changed from accepted to closed
  • Resolution set to fixed

In [19783]:

Translate  http://wordpress.org/ for the wp-login.php header image URL. Clean up. props zeo, fixes #19364.

Note: See TracTickets for help on using tickets.