Opened 18 months ago

Last modified 18 months ago

#19451 new enhancement

Cannot distinguish which WordPress Signup stage I am

Reported by: Cimmo Owned by:
Priority: normal Milestone: Awaiting Review
Component: Multisite Version: 3.3
Severity: minor Keywords: has-patch
Cc:

Description

As a plug-in developer under WordPress MS I would like to recognize at which stage I am of the signup:

  1. first page because of some errors
  2. blog confirmation page in case of no errors

Unluckily as today we have:
<input type="hidden" name="stage" value="validate-blog-signup" />

that is the same for the whole process instead would be nice to have a different value there.

Plus we have:
<?php do_action( 'signup_hidden_fields' ); ?>

But even this action is called in both stages.

So how about start naming the stages differently and also call different actions?
For example I want to include some hidden fields only when I am sure all errors are gone and I am already on confirmation of blog name stage.
I don't see this possible right now.

Attachments (2)

patch.diff (2.4 KB) - added by Cimmo 18 months ago.
New proposed patch that passes tje stage as parameter to the action
patch2.diff (1.7 KB) - added by Cimmo 18 months ago.
New proposed patch with no variable

Download all attachments as: .zip

Change History (7)

comment:1 follow-up: ↓ 2   scribu18 months ago

  • Keywords needs-patch added

I think it would be better if we pass the stage as a parameter to the action, instead of renaming it.

comment:2 in reply to: ↑ 1   Cimmo18 months ago

Replying to scribu:

I think it would be better if we pass the stage as a parameter to the action, instead of renaming it.

But also the stage is always the same! Form id same. Everything is a copy/paste so very hard to understand at which page I am exactly.

EDIT: Nevermind what I said, I am providing a patch already.

Last edited 18 months ago by Cimmo (previous) (diff)
  • Component changed from General to Multisite

Cimmo18 months ago

New proposed patch that passes tje stage as parameter to the action

  • Keywords has-patch added; needs-patch removed
  • Severity changed from normal to minor

That looks better, but I don't think the $stage variable is necessary. Just pass the string directly; so that it matches the one in the hidden <input>.

Cimmo18 months ago

New proposed patch with no variable

Note: See TracTickets for help on using tickets.