Opened 18 months ago
Closed 18 months ago
#19477 closed enhancement (fixed)
RTL for the About page
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | RTL | Version: | 3.3 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
Some screenshots needs to be moved to left at the About page (wp-admin/about.php).
Please check the attachment.
.about-wrap .feature-section.images-stagger-right .feature-images {
right: 0; (should be left)
}
Attachments (11)
Change History (24)
Replying to helenyhou:
19477.diff will move those images to the left. Maybe should be noted that the .three-col features at the bottom are not switched around, either.
Yes, the whole page should be RTLized.
Also this line needs to be aligned to right.
http://core.trac.wordpress.org/attachment/ticket/19477/Untitled-1.2.gif
- Milestone changed from Awaiting Review to 3.3
- Summary changed from Screenshots position at the About page to RTL for the About page
19477.3.diff should take care of everything mentioned above. I had put text-align:right for all of the .three-col h4's at first, hence 19477.2.diff, but it's just added to the inline style in 19477.3.diff.
Heading alignment, cool.
For the record, the screenshots just need to be next to the appropriate text, there's no need for them to be specifically left or right of the text. As anyone who was involved in the original ticket will remember, we bounced them back and forth a bunch of times, so it really doesn't matter, as long as they are in the correct sections of the screen.
<h4 style="direction:ltr;text-align:right"> doesn't do too well on LTR. :-)
Replying to nacin:
<h4 style="direction:ltr;text-align:right"> doesn't do too well on LTR. :-)
Hah, oops. 19477.2.diff then? I'm a master artisan of great foresight.
SergeyBiryukov — 18 months ago
19477.5.diff (based on 19477.2.diff) offers some more adjustments for better compliance with current LTR styles. Fixes .angled-left/.angled-right order and .three-col img padding as well. Added screenshots.
comment:11
koopersmith — 18 months ago
Tested. attachment:19477.5.diff looks solid.
comment:12
nacin — 18 months ago
- Keywords commit added
Looks good. Nice work, helenyhou and SergeyBiryukov.
comment:13
ryan — 18 months ago
- Owner set to ryan
- Resolution set to fixed
- Status changed from new to closed
In [19575]:

19477.diff will move those images to the left. Maybe should be noted that the .three-col features at the bottom are not switched around, either.