Opened 13 years ago
Closed 13 years ago
#19477 closed enhancement (fixed)
RTL for the About page
Reported by: | rasheed | Owned by: | ryan |
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | RTL | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Some screenshots needs to be moved to left at the About page (wp-admin/about.php).
Please check the attachment.
.about-wrap .feature-section.images-stagger-right .feature-images { right: 0; (should be left) }
Attachments (11)
Change History (24)
#2
in reply to:
↑ 1
@
13 years ago
Replying to helenyhou:
19477.diff will move those images to the left. Maybe should be noted that the
.three-col
features at the bottom are not switched around, either.
Yes, the whole page should be RTLized.
#3
@
13 years ago
Also this line needs to be aligned to right.
http://core.trac.wordpress.org/attachment/ticket/19477/Untitled-1.2.gif
#4
@
13 years ago
- Milestone changed from Awaiting Review to 3.3
- Summary changed from Screenshots position at the About page to RTL for the About page
#5
@
13 years ago
19477.3.diff should take care of everything mentioned above. I had put text-align:right
for all of the .three-col h4
's at first, hence 19477.2.diff, but it's just added to the inline style in 19477.3.diff.
#7
@
13 years ago
Heading alignment, cool.
For the record, the screenshots just need to be next to the appropriate text, there's no need for them to be specifically left or right of the text. As anyone who was involved in the original ticket will remember, we bounced them back and forth a bunch of times, so it really doesn't matter, as long as they are in the correct sections of the screen.
#8
follow-up:
↓ 9
@
13 years ago
<h4 style="direction:ltr;text-align:right">
doesn't do too well on LTR. :-)
#9
in reply to:
↑ 8
@
13 years ago
Replying to nacin:
<h4 style="direction:ltr;text-align:right">
doesn't do too well on LTR. :-)
Hah, oops. 19477.2.diff then? I'm a master artisan of great foresight.
#10
@
13 years ago
19477.5.diff (based on 19477.2.diff) offers some more adjustments for better compliance with current LTR styles. Fixes .angled-left
/.angled-right
order and .three-col img
padding as well. Added screenshots.
#11
@
13 years ago
Tested. attachment:19477.5.diff looks solid.
19477.diff will move those images to the left. Maybe should be noted that the
.three-col
features at the bottom are not switched around, either.