Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#19701 closed defect (bug) (fixed)

Remove .button styling from _default_wp_die_handler()

Reported by: ryan Owned by: azaozz
Priority: normal Milestone: 3.3.1
Component: General Version: 3.3
Severity: normal Keywords:
Cc:

Description

These styles seem to be a left over from the install styles. Given that wp_guess_url() is not a reliable way to determine the siteurl from a front page load and that core doesn't seem to need these styles for any of its wp_die() messages, let's remove them.

Attachments (1)

19701.patch (1.7 KB) - added by azaozz 17 months ago.
Replace the button(s) background images with a gradient

Download all attachments as: .zip

Change History (7)

Plugins might be more likely to include Go Back type buttons, so maybe we should preserve some styling. The image gradients need to go though because wp_guess_url() doesn't really work here.

comment:3 follow-up: ↓ 6   ryan17 months ago

Use css3 gradients instead of images and call it good enough?

To test:

  • Remove wp-config.php
  • Visit wp-admin/install.php
  • Note the "Create a Configuration File"
  • Make the button pretty without using images and wp_guess_url()

Replace the button(s) background images with a gradient

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19635]:

Replace background image with CSS3 gradient in wp_die(), fixes #19701

In [19636]:

Replace background image with CSS3 gradient in wp_die(), fixes #19701 for 3.3

comment:6 in reply to: ↑ 3   westi17 months ago

Replying to ryan:

Use css3 gradients instead of images and call it good enough?

Yes, my intention was for us to revisit all our button styles and change to CSS3 so this sounds like a perfect first step.

Note: See TracTickets for help on using tickets.