#20554 closed enhancement (fixed)

3.4 Feature Pointers

Reported by: ryan Owned by: azaozz
Priority: normal Milestone: 3.4
Component: Help/About Version: 3.4
Severity: normal Keywords: has-patch
Cc: ocean90

Description

We need pointers for 3.4 features. Most notably the customizer.

Attachments (6)

20554.diff (4.0 KB) - added by ryan 13 months ago.
Allow multiple pointers per hook name. Rough in pointer to current theme customize link.
20554.2.diff (3.8 KB) - added by scribu 13 months ago.
Filter out dismissed pointers before doing cap checks
20554.3.diff (3.8 KB) - added by ryan 13 months ago.
Refresh
20554.4.diff (2.6 KB) - added by ryan 12 months ago.
Pointer for choosing header image from library
20554.5.diff (3.5 KB) - added by ryan 12 months ago.
custom background too
20554.6.diff (3.5 KB) - added by ryan 12 months ago.
Update phpdoc, make id more generic

Download all attachments as: .zip

Change History (25)

  • Component changed from General to Help/About

Perhaps start with a pointer to the Customize link for the current theme on the themes.php page and a pointer to the customizer sidebar the first time the Customizer is opened.

ryan13 months ago

Allow multiple pointers per hook name. Rough in pointer to current theme customize link.

The customizer itself seems to short-circuit before admin_enqueue_scripts is fired so WP_Internal_Pointers::enqueue_scripts() never runs.

The @since is wrong for pointer_wp340_customize_current_theme_link().

Also, why are we keeping the pointers from 3.3?

Nevermind, I get it: for users that upgrade directly from 3.2 or earlier.

Filter out dismissed pointers before doing cap checks

20554.2.diff: small enhancement: use array_diff() to filter out disabled pointers, before doing cap checks.

  • Keywords has-patch added
  • Cc ocean90 added

ryan13 months ago

Refresh

In [20774]:

First pass at 3.4 pointers. Add pointer to the customize link for the current theme on themes.php. Support multiple pointers per page. Props scribu. see #20554

ryan12 months ago

Pointer for choosing header image from library

There's a pointer for choose from lib. Figuring a pointer for all the things we'll be featuring on the about page. Customizer, choose header from lib, flex headers, html captions.

ryan12 months ago

custom background too

ryan12 months ago

Update phpdoc, make id more generic

In [20839]:

Feature pointers for choosing an image from the library on the custom header and background pages. see #20554

On themes pointer, for 2nd paragraph, maybe change to "Click the Live Preview links in the Available Themes list below to customize and preview another theme before activating it."

In [20854]:

Updated text for Customize pointer. Props jane. see #20554

In [20867]:

Pointers: add arg to pointer options to load at window.loaded (after all images have been loaded and the layout is finalized) and use it on the custom header screen, see #20554

Can we call it defer or defer_loaded? Would like the spelling to be correct. :-)

In [20869]:

s/deffer/defer, see #20554

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [20880]:

Pointers: center pointer on Themes screen, fixes #20554

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is still broken. Chrome. OS X. Load the page. Reload. Points to the wrong location.

  • Resolution set to fixed
  • Status changed from reopened to closed

In [20891]:

Pointers: fix check for defer_loading, fixes #20554

Note: See TracTickets for help on using tickets.