Opened 13 months ago

Last modified 12 months ago

#20663 new enhancement

add_image_size needs a $label

Reported by: wycks Owned by:
Priority: normal Milestone: Awaiting Review
Component: Media Version: 3.3.2
Severity: normal Keywords: needs-patch
Cc: info@…, johnbillion

Description (last modified by SergeyBiryukov)

add_image_size() does not have a $label parameter, this effects both localization but more importantly limits the image_size_names_choose filter.

The is when you try to add an image to a post and you can select sizes via the radio buttons.

Default sizes have labels like: 'large' => __('Large')

the image_size_names_choose filter is a great new filter that allows you to alter those radio buttons, but requires you to hardcore the array values for add_image_size() since it does not have a label (unless I'm missing something).

Reference code: ​https://gist.github.com/2668630

Related: #19990

Change History (4)

comment:1   SergeyBiryukov — 13 months ago

  • Component changed from General to Media
  • Description modified (diff)

comment:2   scribu — 13 months ago

  • Type changed from defect (bug) to enhancement

+1 and we should make the default image sizes be registered using add_image_size(), instead of being hardcoded all over the place.

comment:3   toscho — 13 months ago

  • Cc info@… added

comment:4   johnbillion — 12 months ago

  • Cc johnbillion added
Note: See TracTickets for help on using tickets.