wp.getComments logs in the user (1 + #comments) times

[aercolino]

Also wp.getPages had a similar bug, before [20807].

I've been writing an enhancement for my LoginDongle plugin, where I will use a query string param to allow an XML-RPC user to log in. All calls work fine except getComments and it's because it reuses the getComment() method, which causes the unneeded logins.

​getComments issue
|
​getPages issue

[maxcutler]

Added a patch that moves the formatting logic out into a _prepare_comment method like we've done for all other content types in the 3.4 release. Also fixes a potential source of notices if the caller omits the optional fourth argument.

Added some unit tests for these two methods in ​[UT720].

[westi]

Looks good to me too.

[ryan]

In [20856]:

Introduce _prepare_comment(). Avoid repeated auth attempts. Props maxcutler. fixes #20703

[aercolino]

Thanks :-)