Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#20796 closed enhancement (fixed)

Add Twitter oEmbed to the About 3.4 page

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.4
Component: Help/About Keywords: i18n-change has-patch commit
Focuses: Cc:

Description

We likely underestimated the cool factor of the ability to embed tweets with just a URL. This could be a good time to refresh people on oEmbed while adding one more user feature to the page.

Things we need:

  • A new section
  • Text for that section
  • A screenshot of some sort

Attachments (17)

about-page-twitter-embeds.diff (4.0 KB) - added by chexee 13 years ago.
First pass at a patch.
twitter-embed.png (43.3 KB) - added by chexee 13 years ago.
Twitter embed screenshet
20796-2.patch (6.3 KB) - added by azaozz 13 years ago.
20796-3.patch (5.6 KB) - added by SergeyBiryukov 13 years ago.
20796.flex-header-media-library.png (36.4 KB) - added by SergeyBiryukov 13 years ago.
20796.twitter-embed.png (30.0 KB) - added by SergeyBiryukov 13 years ago.
20796.4.diff (5.5 KB) - added by helenyhou 13 years ago.
20796.twitter-embed.notext.png (28.1 KB) - added by helenyhou 13 years ago.
20796-5.patch (5.5 KB) - added by SergeyBiryukov 13 years ago.
Shorter text
20796.6.diff (5.4 KB) - added by chexee 13 years ago.
twitter-embed-1.png (14.7 KB) - added by chexee 13 years ago.
twitter-embed-2.png (22.0 KB) - added by chexee 13 years ago.
twitter-embed-2.2.png (22.0 KB) - added by chexee 13 years ago.
twitter-embed-2.3.png (16.3 KB) - added by chexee 13 years ago.
20796.7.diff (5.6 KB) - added by nacin 13 years ago.
20796.8.diff (5.6 KB) - added by SergeyBiryukov 13 years ago.
With text tweaks from Jane and helenyhou
20796.9.diff (5.6 KB) - added by SergeyBiryukov 13 years ago.

Download all attachments as: .zip

Change History (50)

#1 @chexee
13 years ago

Sounds like a good idea to me. I definitely think people will be excited about this.

#2 follow-up: @georgestephanis
13 years ago

Suggested tweet to embed:

https://twitter.com/WordPress/status/206804082080497666

Unless someone'd like to get on the Twitter Account and make a tweet specifically about the new tweet oEmbed feature, which would be really meta.

Potential screenshot of the frontend ...

http://cloud.stephanis.info/2F0H3Q1M2z2r2P3G1S0P

and editing the post ...

http://cloud.stephanis.info/1O1o3z0m1i2O0S3W212J

If the Tweet in question look good, I'll draft a summary and get a patch up.

#3 in reply to: ↑ 2 @chexee
13 years ago

Replying to georgestephanis:

Suggested tweet to embed:

https://twitter.com/WordPress/status/206804082080497666

Unless someone'd like to get on the Twitter Account and make a tweet specifically about the new tweet oEmbed feature, which would be really meta.

Potential screenshot of the frontend ...

http://cloud.stephanis.info/2F0H3Q1M2z2r2P3G1S0P

and editing the post ...

http://cloud.stephanis.info/1O1o3z0m1i2O0S3W212J

If the Tweet in question look good, I'll draft a summary and get a patch up.

That's the one I was looking at! :)

Not sure we need a screenshot of the editor, I think some explanatory text would suffice. One image would fit in a bit better with the variety of left/right alignments that are already on the page.

#4 @chexee
13 years ago

Working on a patch:

http://chx.mx/3e0K2I0y1A0Z2e1K3a0D

Also added 1px borders, allowing the shadows to show up so screenshots with white backgrounds don't blend in so much.

I'm going to adjust some of the alignment on the 3 column screenshots. They're a bit off at certain screen widths (especially full screen).

I'm not great with copy writing, so if anyone has some suggestions for the text block that would be great. I'll try to come up with something before I submit a patch :)

#5 follow-up: @georgestephanis
13 years ago

Well, 'better captions' has two pictures, one of the back-end editor, one of the front-end result. And if you just say 'oEmbed works for Twitter' -- I almost feel that a second picture would be worth a thousand words showing how dead simple it actually is to use.

#6 in reply to: ↑ 5 @chexee
13 years ago

Replying to georgestephanis:

Well, 'better captions' has two pictures, one of the back-end editor, one of the front-end result. And if you just say 'oEmbed works for Twitter' -- I almost feel that a second picture would be worth a thousand words showing how dead simple it actually is to use.

I think the captions feature is a more difficult to explain in text and warrants the other screenshot. I think screenshots of the editor with URLs or code make things look more complicated than they actually are (this is totally debatable).

Last edited 13 years ago by chexee (previous) (diff)

#7 @georgestephanis
13 years ago

Last edited 13 years ago by georgestephanis (previous) (diff)

#8 @chexee
13 years ago

Updated the screenshot to read "embed" rather than "oEmbed" per nacin :)

http://chx.mx/0t1C0h1z3b2c0u2L1u1E

Still getting the margins on that 3-column screenshot block right. It's a bit tricky.

@chexee
13 years ago

First pass at a patch.

@chexee
13 years ago

Twitter embed screenshet

#9 @chexee
13 years ago

Attached the screenshot and a patch.

@azaozz
13 years ago

#10 @azaozz
13 years ago

20796-2.patch includes the first patch and tweaks the structural css for the three-images-in-a-row (first is float:left, last is float:right and the middle is text-align:center).

Also noticed that the new screenshot as well as flex-header-media-library.png are larger than the maximum width (525px), so are always scaled. Perhaps better to either trim them or scale them beforehand reducing file size.

#11 @SergeyBiryukov
13 years ago

  • Keywords has-patch added

Minor cleanup:

  • Spaces instead of tabs to align CSS rules (seems more consistent with other instances).
  • Removed a line break from the text block.

While we're at it, is there a reason why the "Faster Translations" block ([20947]) is split into two strings?

Replying to azaozz:

Perhaps better to either trim them or scale them beforehand reducing file size.

Attached the resized images.

#12 @nacin
13 years ago

While we're at it, is there a reason why the "Faster Translations" block ([20947]) is split into two strings?

Because I didn't want to break the first half of the string so late. It's valid, even for RTL, to split up individual sentences.

#13 follow-up: @nacin
13 years ago

I don't like the idea of having instructions in the screenshot, as this is only useful to English users, and we have not yet come up with a system for translating screenshots. Instructions should be included directly in the text, ideally as a second paragraph. This would also make the screenshot shorter, and balance out the height of the screenshot versus the height of the text.

#14 in reply to: ↑ 13 @helenyhou
13 years ago

"Twitter embeds allows you to display any individual tweet in a blog post or post comment, complete with the tweet's text, action links allowing readers to reply, retweet, and favorite tweets without leaving your site, inline links, links to hashtag pages, linked usernames, and a follow button in the tweet."

reads awkwardly. Perhaps shift the items around a bit:

"Twitter embeds allow you to display any individual tweet in a blog post or post comment, complete with the tweet's text, inline links, and linked hashtags and usernames, along with action links allowing readers to follow the user and reply to, retweet, and favorite the tweet without leaving your site."

Replying to nacin:

I don't like the idea of having instructions in the screenshot

The h4 gives you the very basic instructions for use - I would consider the text in the screenshot just additional, but maybe we can chop out the top and bottom text and put a text arrow between the URL and embed instead of words.

#15 follow-up: @nacin
13 years ago

I would be okay with it being a URL and a downwards arrow like ↓, then the embed, in the screenshot.

#16 in reply to: ↑ 15 ; follow-up: @helenyhou
13 years ago

Replying to nacin:

I would be okay with it being a URL and a downwards arrow like ↓, then the embed, in the screenshot.

Maybe like so? http://s.hyhs.me/H4cN

@helenyhou
13 years ago

#17 @helenyhou
13 years ago

20796.4.diff with modified text. Also uploaded a new version of the screenshot without so much text; looks like this: http://s.hyhs.me/H3ZY

#18 in reply to: ↑ 16 @chexee
13 years ago

Replying to helenyhou:

Replying to nacin:

I would be okay with it being a URL and a downwards arrow like ↓, then the embed, in the screenshot.

Maybe like so? http://s.hyhs.me/H4cN

Took this and applied a subtle sharpening filter: http://chx.mx/0R2x3S3t0W1S0M0M161W

#19 follow-up: @nacin
13 years ago

I guess the only concern I have is the <h4> is so long you almost skip it (and it contains the instructions), and then the paragraph is still one big run-on sentence.

#20 @jane
13 years ago

I think the screenshot is massively confusing for someone who doesn't know how to use it. Showing it in the editor and as the live view as two separate images would be better (like with captions).

#21 follow-up: @jane
13 years ago

To be more clear than my comment above, showing the URL as part of the post as displayed on the live site (vs what is put into the editor) with an arrow is inaccurate, and using that as an informational graphic is bad ux. I do not want this method to be used.

#22 @nacin
13 years ago

I agree on two separate images.

#23 in reply to: ↑ 21 @chexee
13 years ago

Replying to jane:

To be more clear than my comment above, showing the URL as part of the post as displayed on the live site (vs what is put into the editor) with an arrow is inaccurate, and using that as an informational graphic is bad ux. I do not want this method to be used.

Agree with this, though not crazy about how the two screenshots show up in the layout. I think this is the better way given the above, but just pointing this out. There are a lot of 3-column spaces in a row.

Images on the left: http://chx.mx/0F3n2u0v043F142c2m00
Images on the right: http://chx.mx/0J243E1G1l431s3W3y42

I prefer right, as my eyes not jumping all over the page to find the text, but it starts to weigh down the right side of the layout.

#24 in reply to: ↑ 19 @SergeyBiryukov
13 years ago

Replying to nacin:

I guess the only concern I have is the <h4> is so long you almost skip it (and it contains the instructions), and then the paragraph is still one big run-on sentence.

We should probably make the header shorter to look more consistent with the others and move the instructions to the text block. How about:

Share Tweets Right in Your Posts

"Twitter embeds allow you to display any individual tweet in a blog post or post comment, along with action links allowing readers to follow and reply to, retweet, and favorite the tweet without leaving your site. Just paste a Tweet URL on its own line."

#25 @nacin
13 years ago

I would remove "follow and"... As it's for following the user, nor the tweet. It's okay if we don't describe the entire embed.

I would still like to remove all text from the images. A headline of "WordPress 3.4 + Twitter" seems fine, with just the URL.

@SergeyBiryukov
13 years ago

Shorter text

@chexee
13 years ago

#26 @chexee
13 years ago

Attached a patch and screenshots with one copy change: Removed the word "right" from "Share Tweets Right in Your Posts" to read "Share Tweets in Your Posts"

Result: http://chx.mx/1624101V0R0a1b26173M

Last edited 13 years ago by chexee (previous) (diff)

@nacin
13 years ago

#27 @nacin
13 years ago

With twitter-embed-1.png and twitter-embed-2.3.png, and 20796.7.diff, I think we have it: http://cl.ly/2e0s1R0Z3q2w3d3k0b2u.

Twitter embeds allow you to display individual tweets in posts. It includes action links that allow readers to reply to, retweet, and favorite the tweet without leaving your site. Just paste a tweet URL on its own line.

This works with other sites, too. For more, see the Codex article on <a>Embeds</a>.

#28 @nacin
13 years ago

  • Keywords commit added

#29 follow-up: @jane
13 years ago

The new images are perfect.

Since it works in pages as well as posts, that subhead "Share Tweets in Your Posts" might be better as "Share Tweets with Style".

"This works with other sites, too" makes sense to those of us who think site = oembed provider, but I would bet cash money that lots of people would read that and think it meant you could paste the tweet into a Facebook post or in a discussion board somewhere and have it show the same. What we really mean is "This works with links from other sites, too."

#30 in reply to: ↑ 29 @helenyhou
13 years ago

Replying to jane:

What we really mean is "This works with links from other sites, too."

It'd be better to say URLs instead of links (as it says above that text), as oEmbed doesn't work for hyperlinked text.

@SergeyBiryukov
13 years ago

With text tweaks from Jane and helenyhou

#31 follow-up: @nacin
13 years ago

Looks good. How about "This works with URLs from some other sites, too." Note the addition of "some" (could also be "many") — because I would bet cash money that lots of people would read that and think it meant you could paste lots of URLs on their own line and have it show the same. I think the link to the Codex should alleviate those questions, but still, worth a consideration.

#32 in reply to: ↑ 31 @SergeyBiryukov
13 years ago

Replying to nacin:

How about "This works with URLs from some other sites, too." Note the addition of "some"

Makes sense, 20796.9.diff

#33 @nacin
13 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [20977]:

New section on Twitter Embeds on the about page. props georgestephanis, chexee, azaozz, SergeyBiryukov, jane. fixes #20796.

Note: See TracTickets for help on using tickets.