WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 8 months ago

#20887 closed defect (bug) (worksforme)

Widget titles - some characters cropped

Reported by: pavelevap Owned by:
Priority: low Milestone:
Component: UI Version: 3.2
Severity: minor Keywords: has-patch
Cc: pavelevap@…

Description

Some characters are cropped in widget titles in administration, please see attached screenshot (using latest trunk, Chrome).

1) Current situation (cropped "j" characters").

2) Removing line-height: 1; shows all characters, but the whole title is moved a little down.

Attachments (6)

Widget_titles.jpg (7.7 KB) - added by pavelevap 13 months ago.
20887.patch (489 bytes) - added by SergeyBiryukov 13 months ago.
20887.after.png (6.1 KB) - added by SergeyBiryukov 13 months ago.
20887.tag-cloud.png (6.1 KB) - added by SergeyBiryukov 12 months ago.
20887.2.patch (477 bytes) - added by SergeyBiryukov 10 months ago.
Refreshed after [21592]
20887.3.patch (528 bytes) - added by lessbloat 10 months ago.
Added note about odd line height in CSS.

Download all attachments as: .zip

Change History (19)

pavelevap13 months ago

comment:1 alexvorn213 months ago

maybe the problem is in the translated text?

comment:2 pavelevap13 months ago

I do not think so, tested also in original english version, you can see this problem for example at "Categories" widget.

comment:3 alexvorn213 months ago

maybe to remove the overflow property instead of line-height...
not only j character is cropped but p, g also...

comment:4 alexvorn213 months ago

  • Keywords needs-patch added
  • Severity changed from normal to major

comment:5 nacin13 months ago

Is this a problem in 3.3, or just 3.4?

comment:6 pavelevap13 months ago

I noticed this problem also in 3.2.1.

comment:7 alexvorn213 months ago

@nacin Version 3.3.2, 3.4 too

comment:8 ocean9013 months ago

  • Version changed from 3.4 to 3.2

comment:9 azaozz13 months ago

  • Component changed from Widgets to UI
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from major to minor

This is dependent on the font and the browser. Generally line-height: 1; shouldn't hide the top and bottom bits of letters only make the lines "touch" vertically. However some browsers don't render this properly.

Thinking there are few more places where this may be happening.

(BTW, perhaps we need "CSS" component for things like this?)

SergeyBiryukov13 months ago

SergeyBiryukov13 months ago

comment:10 SergeyBiryukov13 months ago

  • Keywords has-patch added; needs-patch removed

comment:11 SergeyBiryukov12 months ago

  • Milestone changed from Future Release to 3.5

To reproduce, move Tag Cloud widget to the Inactive Widgets area (20887.tag-cloud.png).

20887.patch fixes that as well. Tested in Firefox 13, Chrome 19, IE 8, Opera 11.64.

SergeyBiryukov10 months ago

Refreshed after [21592]

lessbloat10 months ago

Added note about odd line height in CSS.

comment:12 lessbloat10 months ago

While I couldn't replicate the issue without the patch, after applying the patch, everything looks fine.

comment:13 SergeyBiryukov8 months ago

  • Milestone 3.5 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Tested again in Firefox 15, Chrome 22, IE 7, IE 8, Opera 12.

Could not reproduce Widget_titles.jpg or 20887.tag-cloud.png in current trunk.

Note: See TracTickets for help on using tickets.