Opened 14 years ago
Closed 12 years ago
#21000 closed defect (bug) (worksforme)
custom-background still include background-image: none; when setting background color
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 3.4 |
| Component: | General | Keywords: | has-patch close |
| Focuses: | Cc: |
Description
I am sorry I missed this after the last inclusion before release, but in the function _custom_background_cb()
I overlooked testing logic in the callback before it was released.
if background color was specified but no image, act as if image shouldn't exist
The original complaint was that when you removed (both) the $background and $color that it outputted the background-image: none; However in 3.4 it's not account for $color in the function and !$background
This is the change I am requesting.
if ($background) {
...
line: 1136 - wp-includes/theme.php
} else $style .= ' background-image: none;';
This will make it handle the if ($color && !background) appropriately
Attachments (2)
Change History (11)
#2
@
13 years ago
- Version set to 3.4
background-image: none is no longer there. I cannot tell if you are proposing that we add a line or remove a line. Could you build a proper SVN patch so we can get a better idea?
#6
@
13 years ago
- Keywords needs-testing removed
Tested the patch and it works well. I also recreated the patch so that it will easily apply.
Related: #20132