WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#21054 closed defect (bug) (fixed)

+1px widget placeholder height

Reported by: alexvorn2's profile alexvorn2 Owned by: markjaquith's profile markjaquith
Milestone: 3.5 Priority: normal
Severity: trivial Version: 3.4
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

ui.placeholder.height(ui.item.height()) this will make the placeholder to have the same size as the widget, or we can add ui.placeholder.height(27) for 27 pixel height for the placeholder. (in the start event of '.widgets-sortables' function in widgets.js)

Attachments (3)

21054.png​ (6.2 KB) - added by SergeyBiryukov 12 years ago.
21054.patch​ (353 bytes) - added by SergeyBiryukov 12 years ago.
21054.after.png​ (6.2 KB) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (7)

@SergeyBiryukov
12 years ago

@SergeyBiryukov
12 years ago

@SergeyBiryukov
12 years ago

#1 @SergeyBiryukov
12 years ago

  • Keywords has-patch added; needs-patch removed

As far as I can see, the issue is that placeholders are 1px shorter than widget titles (21054.png​).

21054.patch​ fixes that. Tested in Firefox 13, Chrome 19, IE 8, Opera 11.64.

#2 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.5
  • Severity changed from normal to trivial

#3 @georgestephanis
12 years ago

I approve of this patch. :: thumbs up campaign ad ::

#4 @markjaquith
12 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In [21244]:

Increase the height of the widget drag/drop placeholder by one pixel so it matches the size of the dragged widget. props alexvorn2. props SergeyBiryukov. fixes #21054

Note: See TracTickets for help on using tickets.