WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#21073 closed enhancement (wontfix)

Main functions file (/wp-includes/functions.php) could use a coding standards cleanup

Reported by: evansolomon's profile evansolomon Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

​This file is very inconsistent in its coding standards, and as a result is difficult to read.

I had to find a couple things in here recently; after some frustration in reading the different styles I decided to take a pass at refreshing it.

Attachments (1)

21073.diff​ (63.1 KB) - added by evansolomon 12 years ago.

Download all attachments as: .zip

Change History (4)

@evansolomon
12 years ago

#1 @c3mdigital
11 years ago

  • Keywords has-patch removed
  • Resolution set to maybelater
  • Status changed from new to closed

As much as I'm for coding standards I will refer to: ​http://make.wordpress.org/core/2011/03/23/code-refactoring/

Refactoring patches require unit tests, performance benchmarks, proper justification and clear rationale.

#2 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution changed from maybelater to wontfix

Formatting cleanup tickets are generally discouraged. Coding style fixes should be a result of more substantial changes.

#3 @SergeyBiryukov
11 years ago

  • Keywords has-patch added
Note: See TracTickets for help on using tickets.