WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 12 years ago

#21087 closed defect (bug) (fixed)

Combine some similar strings

Reported by: pavelevap's profile pavelevap Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.4
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Combine some similar strings with the same meaning - related to the same condition. There is no need to have several different strings.
See attached patch.

Related to #18218, but a little different (not mentioned) case. There are 3 removed strings as a result of this patch.

Attachments (2)

similar_strings.patch​ (1.9 KB) - added by pavelevap 13 years ago.
21087.patch​ (892 bytes) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (9)

@pavelevap
13 years ago

#1 @SergeyBiryukov
13 years ago

  • Milestone changed from Awaiting Review to 3.5

#2 @wonderboymusic
12 years ago

  • Keywords has-patch added

#3 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21857]:

Combine some strings. props pavelevap. fixes #21087.

@SergeyBiryukov
12 years ago

#4 @SergeyBiryukov
12 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

21087.patch​ removes one more duplicated string and makes it more consistent with the ones above. Reported by Cátia Kitahara on ​WP Polyglots.

#5 follow-up: @pavelevap
12 years ago

I found other similar strings: "Select Color" and "Select a color". I am not sure which is right and which should be merged?

#6 @ryan
12 years ago

In 22854:

Consolidate some strings. Props SergeyBiryukov. see #21087

#7 in reply to: ↑ 5 @nacin
12 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to pavelevap:

I found other similar strings: "Select Color" and "Select a color". I am not sure which is right and which should be merged?

Let's leave that alone for now (so, two strings). One is a TinyMCE button tooltip, which has its own style. The other is a "Select Color" button for the color picker.

Note: See TracTickets for help on using tickets.