error_log() not called in wp-db.php when error_log setting is empty

[apimlott]

The fix for #5771 is still not right. If the error_log setting in php.ini is empty (the default), errors should still be logged. (See ​http://www.php.net/manual/en/errorfunc.configuration.php#ini.error-log.) But in this case, ini_get('error_log') returns an empty string, so the iswritable check in wp-includes/wp-db.php line 935 (WordPress 3.4) fails and nothing is logged. Probably, there should be an test for empty string just as there is for 'syslog'.

Patch attached.

Patch against WordPress 3.4

I was wrong about one thing. The is_writable check doesn't fail, it fails earlier because the empty return from ini_get is considered false. That's why I pulled the call to ini_get out of the condition.

Can't we just always call error_log()? The conditional, function_exists, and error suppression all seem unnecessary.

yeah, the whole thing looks like overkill

In [21807]:

Call error_log() in wp-db without unnecessary conditionals. fixes #21103.