Opened 11 months ago

Closed 10 months ago

#21259 closed defect (bug) (fixed)

Twenty Twelve: Definition Lists

Reported by: sennza Owned by: lancewillett
Priority: normal Milestone: 3.5
Component: Bundled Theme Version:
Severity: normal Keywords: has-patch
Cc: bronson@…, konstantin@…, lancewillett

Description

The layout test shows there needs to be some tweaks for definition lists.

Attachments (4)

definition-list-before.jpg​ (157.2 KB) - added by sennza 11 months ago.
definition-list-after.jpg​ (161.9 KB) - added by sennza 11 months ago.
21259.patch​ (611 bytes) - added by sennza 11 months ago.
21259.1.patch​ (541 bytes) - added by drewstrojny 10 months ago.

Download all attachments as: .zip

Change History (15)

comment:1   nacin — 11 months ago

  • Milestone changed from Awaiting Review to 3.5

sennza — 11 months ago

sennza — 11 months ago

sennza — 11 months ago

comment:2   sennza — 11 months ago

  • Cc bronson@… added

comment:3   obenland — 11 months ago

  • Component changed from General to Bundled Theme

comment:4   obenland — 10 months ago

  • Cc konstantin@… added

drewstrojny — 10 months ago

comment:5   lancewillett — 10 months ago

  • Cc lancewillett added

comment:6   lancewillett — 10 months ago

Drew, shouldn't 21259.1.patch also have the margin: 0 24px; as fallback for rem value?

comment:7   lancewillett — 10 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21337]:

Twenty Twelve: adjust styles for definition lists, props sennza and drewstrojny. Fixes #21259.

comment:8 follow-up: ↓ 10   obenland — 10 months ago

Now both <dt> and <dd> elements have a margin-bottom of 1.714285714rem, ​which looks odd (to me).
Wouldn't 1rem or 0,714285714rem make more sense?

comment:9   SergeyBiryukov — 10 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:10 in reply to: ↑ 8   lancewillett — 10 months ago

Replying to obenland:

Now both <dt> and <dd> elements have a margin-bottom of 1.714285714rem, ​which looks odd (to me).
Wouldn't 1rem or 0,714285714rem make more sense?

You are correct, the dt element should have no bottom margin, or very little.

comment:11   lancewillett — 10 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21372]:

Twenty Twelve: improve definition term layout a bit, use line-height instead of bottom margin. Fixes #21259.

Note: See TracTickets for help on using tickets.