WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#21259 closed defect (bug) (fixed)

Twenty Twelve: Definition Lists

Reported by: sennza's profile sennza Owned by: lancewillett's profile lancewillett
Milestone: 3.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The layout test shows there needs to be some tweaks for definition lists.

Attachments (4)

definition-list-before.jpg​ (157.2 KB) - added by sennza 13 years ago.
definition-list-after.jpg​ (161.9 KB) - added by sennza 13 years ago.
21259.patch​ (611 bytes) - added by sennza 13 years ago.
21259.1.patch​ (541 bytes) - added by drewstrojny 13 years ago.

Download all attachments as: .zip

Change History (15)

#1 @nacin
13 years ago

  • Milestone changed from Awaiting Review to 3.5

@sennza
13 years ago

@sennza
13 years ago

@sennza
13 years ago

#2 @sennza
13 years ago

  • Cc bronson@… added

#3 @obenland
13 years ago

  • Component changed from General to Bundled Theme

#4 @obenland
13 years ago

  • Cc konstantin@… added

@drewstrojny
13 years ago

#5 @lancewillett
13 years ago

  • Cc lancewillett added

#6 @lancewillett
13 years ago

Drew, shouldn't 21259.1.patch also have the margin: 0 24px; as fallback for rem value?

#7 @lancewillett
13 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In [21337]:

Twenty Twelve: adjust styles for definition lists, props sennza and drewstrojny. Fixes #21259.

#8 follow-up: @obenland
13 years ago

Now both <dt> and <dd> elements have a margin-bottom of 1.714285714rem, ​which looks odd (to me).
Wouldn't 1rem or 0,714285714rem make more sense?

#9 @SergeyBiryukov
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 in reply to: ↑ 8 @lancewillett
13 years ago

Replying to obenland:

Now both <dt> and <dd> elements have a margin-bottom of 1.714285714rem, ​which looks odd (to me).
Wouldn't 1rem or 0,714285714rem make more sense?

You are correct, the dt element should have no bottom margin, or very little.

#11 @lancewillett
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [21372]:

Twenty Twelve: improve definition term layout a bit, use line-height instead of bottom margin. Fixes #21259.

Note: See TracTickets for help on using tickets.