Opened 10 months ago
Closed 9 months ago
#21441 closed defect (bug) (fixed)
Twenty Twelve: full RTL support
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | obenland, yoavf |
Description
Review, test, and fix RTL stylesheets.
- rtl.css (main)
- editor-style-rtl.css (editor stylesheet)
Attachments (11)
Change History (31)
- Keywords needs-patch added; needs-refresh removed
- Type changed from task (blessed) to defect (bug)
- Keywords has-patch added; needs-patch removed
My first ever RTL stylesheet: rtl.css
SergeyBiryukov — 10 months ago
comment:4
SergeyBiryukov — 10 months ago
21441.2.diff adds a missing margin-left for .commentlist .children and combines a couple of similar styles in the @media block.
iandstewart — 10 months ago
We ought not to RTL image alignment since the editor adds the class and the button is always the same
comment:5
lancewillett — 10 months ago
In [21430]:
comment:6
lancewillett — 10 months ago
In [21431]:
comment:7
lancewillett — 10 months ago
In [21432]:
comment:8
lancewillett — 10 months ago
In [21433]:
comment:9
lancewillett — 10 months ago
In [21434]:
SergeyBiryukov — 10 months ago
The "Post author" badge needs RTL treatment: 21441.post-author.png.
The order is wrong, so the margins (which are correct per se) also don't look right.
http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwelve/rtl.css#L134
comment:11
obenland — 10 months ago
In 21441-editor-body.diff: Per IRC Chat with @azaozz, center the editor body in RTL to stop messing with calculating height/width in js
comment:12
follow-up:
↓ 14
lancewillett — 10 months ago
In [21441]:
comment:13
lancewillett — 10 months ago
Chatted with Yoav Farhi, he's going to help do a full RTL review for us.
comment:14
in reply to:
↑ 12
azaozz — 10 months ago
Replying to lancewillett:
Was thinking to center the editor body by default (in the default editor css) and then add light grey background to the html element. Makes a lot better looking editor when the body has max-width.
Also, there are more classes on the body in TinyMCE: mceContentBody content post-type-post. The first one is always there (set by MCE) the second is the editor ID and third is the post type. So .content can be used to target only the main TinyMCE instance on the Edit Post screen. DFW gets mceContentBody content post-type-post wp-fullscreen-editor.
comment:15
lancewillett — 10 months ago
In [21483]:
Removed the auto value form the body margin (it wasn't set in ltr), and fixed a few selectors and missing rules
comment:16
follow-up:
↓ 17
yoavf — 10 months ago
- Cc yoavf added
rtl.css looks great, haven't found any problems so far, but I have some more testing to do :)
comment:17
in reply to:
↑ 16
lancewillett — 9 months ago
Replying to yoavf:
rtl.css looks great, haven't found any problems so far, but I have some more testing to do :)
Thanks much for looking and the patch.
comment:18
lancewillett — 9 months ago
In [21515]:
comment:19
lancewillett — 9 months ago
In [21565]:
comment:20
lancewillett — 9 months ago
- Keywords has-patch removed
- Resolution set to fixed
- Status changed from new to closed
RTL should be up to date with latest changes. If new issues arise, please open a new Trac ticket.

First stab. Tested with Theme Unit Test.