Opened 9 months ago
Closed 7 months ago
#21728 closed defect (bug) (fixed)
Consolidate some strings related to user login
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | I18N | Version: | 3.4.1 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | pavelevap@… |
Description
See attached patch. These corrected strings have two variants only with small changes. As a result of suggested unification, we can remove several similar strings.
Attachments (3)
Change History (10)
comment:1
SergeyBiryukov — 9 months ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 3.5
SergeyBiryukov — 9 months ago
comment:3
SergeyBiryukov — 9 months ago
<strong>ERROR</strong>: The e-mail address isn’t correct.
<strong>ERROR</strong>: The email address isn’t correct.
One of these strings is in admin-$locale.po, the other one is in $locale.po. I guess they will remain in both files. However, there's a similar string in admin-$locale.po that can be merged:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/ms.php#L225
Added in 21728.patch. "e-mail" vs. "email" is currently inconsistent, but that can be left for #14366.
The requested user does not exist.
That user does not exist.
Please enter a correct email address.
Please enter a valid email address.
<strong>ERROR</strong>: This username is already registered, please choose another one.
<strong>ERROR</strong>: This username is already registered. Please choose another one.
Same as above, they're in different files. I guess it still might make sense to consolidate them for easier translation.
Thank you, Sergey! I did not notice this string in MS admin.
I think that merged strings will remain only in one file, see related ticket #20881.
Yes, the main purpose of this ticket was not problem "email" versus "e-mail", but only one small step to consolidate similar strings and make translators a little happier...
e-mail vs email: #14366