Ticket #2180 (closed defect (bug): fixed)

Opened 6 years ago

Last modified 2 years ago

Closed comments doesn't surround the output of comments_popup_link with a class

Reported by: Michael Owned by: rob1n
Priority: normal Milestone: 2.2
Component: Template Version: 2.0
Severity: normal Keywords: has-patch commit
Cc:

Description

When using comments_popup_link, the fourth parameter sets the class of the link around the comments. However, if the comments are closed on an entry, no class is set. It would perhaps be preferable if there was a 'before' and 'after' parameter set, so one could surround the comment with a span or something similar.

Attachments

2180.diff Download (503 bytes) - added by rob1n 5 years ago.

Change History

rob1n — 5 years ago

comment:1   rob1n — 5 years ago

  • Keywords has-patch 2nd-opinion added; comments "comments_popup_link" "template tag" removed
  • Owner changed from anonymous to rob1n
  • Milestone set to 2.2

Any thoughts? I'm impartial, really.

comment:2   Nazgul — 5 years ago

From a user point of view I'm impartial as well.

From a programmers point of view I'm in favor of this patch. I have the option to pass a css class to the function, which then isn't used consistently. That seems counter-intuitive.

comment:3   rob1n — 5 years ago

I agree.

comment:4   rob1n — 5 years ago

  • Keywords commit added; 2nd-opinion removed

comment:5   rob1n — 5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [5165]) Add CSS class in if it's not empty when there's no comments. fixes #2180

Note: See TracTickets for help on using tickets.