Janky behavior with imageEdit.scaleChanged() in inline image editor

[DrewAPicture]

As noted in ticket:21391:39, there's some janky behavior when tabbing between the width and height scaling values in the inline image editor. Tabbing between values appears to increment the values down 1 unit at a time. Short screencast to illustrate: ​http://screencast.com/t/tPiq9KlYVzzj

My best guess is something with the imageEdit logic in image-edit.js. Javascript is not my forte.

I reproduced in FF15 on trunk and @ocean90 in Chrome on 3.4.2.

[DrewAPicture]

The scaling ratio works, there's just some weirdness with moving between the values. I propose we look at this in the next cycle.

[helenyhou]

You know... I bet it's a problem with rounding. Looks like it's probably floor-ing, which will keep ticking numbers down if it doesn't divide evenly. Just tried it on a square image and it didn't do that, but can reproduce on others. Not sure about a punt - does feel kind of buggy.

[SergeyBiryukov]

this.intval() removes the fractional part, which leads to unwanted decrementing.

Math.round() gives more accurate results and doesn't trigger unwanted incrementing in my testing.

[SergeyBiryukov]

To reproduce:

1. Click "Edit Image" on a non-square image (e.g. 1000 × 662).
2. Click "Scale Image".
3. If the width is 1000px, change that to a non-round number (e.g. 999 × 661).
4. Keep tabbing between the width and height values. You'll see 998 × 661, 996 × 660, 995 × 659, 993 × 658, etc.

[nacin]

In 22592:

Round rather than floor values in image editing JS to avoid decrementing values on each run. props SergeyBiryukov. fixes #22011.