Opened 6 months ago
Closed 6 months ago
#22449 closed defect (bug) (fixed)
Spinner causes row to grow in height
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.5 |
| Component: | Administration | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
When replying to a comment, the spinner that gets shown briefly is a bit taller than the row (when you add in padding, line height, etc), causing the row to grow by a pixel or two. It then shrinks again when the spinner is hidden. Related to switching from visibility: visible/hidden to display: none in #21456.
Attachments (3)
Change History (11)
Well, now it loses a few pixels after the spinner goes away. I'll take another stab at it.
Replying to lessbloat:
Well, now it loses a few pixels after the spinner goes away. I'll take another stab at it.
Never mind. My local install was causing me problems, which threw a false alarm. 22449.diff should do it.
SergeyBiryukov — 6 months ago
comment:5
SergeyBiryukov — 6 months ago
- Keywords has-patch added
Tested, looks good.
22449.2.diff does the same without duplicating the additional rules.
- Keywords commit added
Because it's only two shared rules, 22449.diff is a bit easier to grasp.
SergeyBiryukov — 6 months ago
comment:7
SergeyBiryukov — 6 months ago
My only (minor) concern with 22449.diff is that it leaves
inline-edit-save .spinner by itself in the /* reply to comments */ block, where it doesn't actually belong.
22449.3.diff moves it to the Inline Editing block.
22449.diff should do the trick.