Opened 13 years ago
Closed 13 years ago
#22632 closed defect (bug) (fixed)
media.view.MediaFrame.restoreThickbox() not called in all cases
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | Media | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
media.view.MediaFrame.restoreThickbox()
is not called (and thus window.tbRemove()
is not restored), when the new Media Manager is just closed (by clicking on the X or the gray border area). It is only called when the Media Manager is closed when something is inserted into the editor (e.g. "Insert into Post").
This breaks the closing behavior of other Thickboxes on the page, as tbRemove()
is then not available.
Attachments (2)
Change History (7)
Note: See
TracTickets for help on using
tickets.
Patch ensures modal events are always fired on its frame.
Easist way to test this is to open the modal, type
tb_remove
in a Webkit console (where it will display the source), close the modal, and typetb_remove
again (or if you're feeling frisky, set them to variables and run an equality test). Did they output the same thing? No? Good.