WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#22688 closed defect (bug) (fixed)

Unused media strings

Reported by: dimadin's profile dimadin Owned by: nacin's profile nacin
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch
Focuses: Cc:

Description

There are a few strings in wp_enqueue_media() that aren't used anywhere. I tried to backtrace when they were introduced and stopped being used, but since there are many related commits, I failed.

Attachments (1)

unused_media_strings.patch​ (1.2 KB) - added by dimadin 12 years ago.

Download all attachments as: .zip

Change History (6)

@dimadin
12 years ago

#1 follow-up: @nacin
12 years ago

createGalleryTitle might still get used at one point. Yep, you're right about the other ones.

#2 @pavelevap
12 years ago

  • Cc pavelevap@… added

#3 in reply to: ↑ 1 @nacin
12 years ago

Replying to nacin:

createGalleryTitle might still get used at one point. Yep, you're right about the other ones.

createGalleryTitle is again used. The other ones can go.

#4 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23011:

Media: Remove four unused strings. props dimadin. fixes #22688.

#5 @nacin
12 years ago

  • Milestone changed from Awaiting Review to 3.5
Note: See TracTickets for help on using tickets.