Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#22710 closed defect (bug) (fixed)

TypeError: router is null when editing a gallery (media-views.js line 505)

Reported by: nacin's profile nacin Owned by: markjaquith's profile markjaquith
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

We're doing router = frame.router.get(), then router.get() again.

It should either be view = frame.router.get() then use view, or router = frame.router then use router.get(). Since we pass a value to get(), it should be the latter.

Via markjaquith in IRC.

Attachments (1)

22710.diff (625 bytes) - added by nacin 12 years ago.

Download all attachments as: .zip

Change History (4)

@nacin
12 years ago

#1 @nacin
12 years ago

  • Keywords has-patch commit added

#2 @markjaquith
12 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23015:

Fix a typo in media-views.js that referenced frame.router.get() instead of frame.router. Fixes #22710

#3 @nacin
12 years ago

This led to #22715, which led to #22930. There, we got it right.

Note: See TracTickets for help on using tickets.