get_attachment_template() doesn't follow the pattern of its get_{type}_template() siblings

[rulatir]

The get_attachment_template() function in template.php is implemented differently from most other get_{type}_template() functions.

Other functions build a list of candidates and pass it to get_query_template(), but get_attachment_template() checks the candidates by itself as it goes, and only calls get_query_template('archive') for the basic case.

I cannot see a reason for this, so I am tentatively filing this as a code quality issue.

(N.b. I am refactoring these functions as part of implementing #23142. In most of them the generation of the candidates list can be trivially factored out with demonstrable correctness, but get_attachment_template() is a harder case due to this inconsistency).

[SergeyBiryukov]

Introduced as get_subpost_template() in [2958], renamed to get_attachment_template() in [3092].

[rulatir]

[nevermind; in this comment I made an observation that I later found to be incorrect]

[rulatir]

Replying to SergeyBiryukov:

Btw. that was the fastest anyone has ever implemented my enhancement request :)

[SergeyBiryukov]

Turned out to be a duplicate of #15337.