get_users() cannot include AND exclude

[dlim_vernier]

The codex describes the parameters for get_users() as an array of options, so it seems like you can set an array of includes and an array of excludes. But the code looks like it can only do one or the other. It would be a simple fix.

Lines 521-527 in wp-includes/user.php

if ( !empty( $qv['include'] ) ) {
	$ids = implode( ',', wp_parse_id_list( $qv['include'] ) );
	$this->query_where .= " AND $wpdb->users.ID IN ($ids)";
} elseif ( !empty($qv['exclude']) ) {
	$ids = implode( ',', wp_parse_id_list( $qv['exclude'] ) );
	$this->query_where .= " AND $wpdb->users.ID NOT IN ($ids)";
}

To fix, change the elseif to its own if:

if ( !empty( $qv['include'] ) ) {
	$ids = implode( ',', wp_parse_id_list( $qv['include'] ) );
	$this->query_where .= " AND $wpdb->users.ID IN ($ids)";
}

if ( !empty($qv['exclude']) ) {
	$ids = implode( ',', wp_parse_id_list( $qv['exclude'] ) );
	$this->query_where .= " AND $wpdb->users.ID NOT IN ($ids)";
}

Thanks for the consideration.

[knutsp]

Use case?

Otherwise, update Codex to reflect that when include is used, there is no exclude.

[bananastalktome]

Replying to knutsp:

Otherwise, update Codex to reflect that when include is used, there is no exclude.

Just as a note, if updating the Codex to note that include & exclude are mutually exclusive,
​http://codex.wordpress.org/Function_Reference/wp_dropdown_users should be updated as well since it takes include & exclude args which are passed to get_users().

[jdgrimes]

Added notes about this in the codex:
​http://codex.wordpress.org/Function_Reference/get_users#Parameters
​http://codex.wordpress.org/Function_Reference/wp_dropdown_users#Parameters

[jnhghy]

would adding a parameter to solve the priority be a solution? like 'priority'=>'include' or 'priority'=>'exclude' with a default for any of them?

[helen]

I'm closing this - I don't see why you would expect include and exclude to work at the same time in a single query, and the Codex has been updated. Feel free to reopen with a concrete example of why this is necessary in a core API.