WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 10 years ago

#23428 closed defect (bug) (wontfix)

comments_open causes PHP notice in certain cases

Reported by: willnorris's profile willnorris Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.5
Component: Comments Keywords: has-patch close
Focuses: Cc:

Description

when comments_open() is called for a non-existant post (either a bad ID, or no ID passed and called from a non-single page), a PHP notice is caused. Ideally, plugins shouldn't be doing this, but a simple null check in comments_open() fixes the problem.

Attachments (1)

comment-template.diff​ (448 bytes) - added by willnorris 13 years ago.

Download all attachments as: .zip

Change History (6)

@willnorris
13 years ago

#1 @willnorris
13 years ago

oh, and the PHP Notice that is triggered is:

Notice: Trying to get property of non-object in .../wordpress/wp-includes/comment-template.php on line 776

#2 @SergeyBiryukov
13 years ago

  • Component changed from Comments to Warnings/Notices
  • Version changed from trunk to 2.5

pings_open() has the similar code (introduced in [6716]):
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/comment-template.php#L789

Seems like the notice is appropriate in the case if a non-existent post, not sure if we should hide it. Related: ticket:17299:6.

Last edited 13 years ago by SergeyBiryukov (previous) (diff)

#3 @markoheijnen
13 years ago

Maybe doing_it_wrong message?. A PHP notice isn't really telling something.

#4 @nacin
12 years ago

  • Component changed from Warnings/Notices to Comments

#5 @rachelbaker
10 years ago

  • Keywords close added
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Displaying a PHP Notice when the $post_id is invalid is expected behavior to me.

Note: See TracTickets for help on using tickets.